During test fitting both the oem pump and aftermarket both fouled the tank, and failed the “pull up with string” test, so 99% sure,
I also went to great lengths to measure the protrusion of the sender unit and space for it in the tank, I made a approx 4”x3” cylinder of cardboard that replicated the size of the pump assembly and put cling film over one end and trial fitted that in the rubber gasket mounted in the tank and it was clear the tank impinged on where the swivelling part of the sender needs to go. The clearance I created is still only a few mm so I doubt the fuel capacity would change much due to the wall moving enough to jam the sender.
Before doing the above I established no amount of bending the float wire resulted in the passing the “string” test, and due to lots of trial and error
I have now found the best way of bending that wire (see pics), so the wire clears the quite narrow gap between front and rear walls, and that the float does not get stuck on the ledge on the rear wall when the tank is full.
There are several issues that result in the sender not working, impacting the tank (regardless of a vacuum) is just one of them. I am still pretty determined to remove any possibility of a vacuum occurring by some mod to create a simple vent. I am pretty fed up with draining the tank and fitting and refitting the pump assembly
I don’t want to have buy another pump and fit it.
The e36 forums have some info on mods to race cars where the oem vent system is not working for one reason or another, and according to the z3 parts diagrams the “other” hose to the pump assembly IS a fuel return, and there is a third hose (I think) that goes to the charcoal cannister. I’m still researching all that though.